PR Custody

MCPG-275 - fix(siem): enforce character limits on log-forwarding fields

@arthurterozendi-plankchecks n/achecks…fix/siem-field-validation → main8 files · +323 −27updated 14h ago

▸Description· 3 comments · 3 noise

Problem

The SIEM Log Forwarding config screen accepted unlimited input — the client form schema declared every field as a bare optional string (no max, no maxLength, no feedback), apiKey was uncapped everywhere, the config fields were capped only on the save path (not test), and endpoint URLs had no length cap.

Fix

Added shared length constants in @repo/types as the single source of truth: SIEM_API_KEY_MAX_LENGTH (256), SIEM_CONFIG_FIELD_MAX_LENGTH (100), SIEM_ENDPOINT_MAX_LENGTH (2048).
Applied them across the canonical save/test/stored schemas, the client form schema, and as HTML maxLength attributes with per-field error display (Datadog fields surfaced no errors before).

Limits

Informed by official provider docs — Datadog API key (32-hex), Splunk HEC token (36-char GUID), Datadog tag cap (200), Splunk index (~255 OS limit). The apiKey cap is generous-but-bounded rather than an exact match: the reuse sentinel flows through the same field on the test path and Test Connection validates the live credential, so the cap only rejects unbounded input.

@arthurterozendi-plank14h ago

@codex review

@arthurterozendi-plank14h ago

@codex review

@chatgpt-codex-connector[bot]agent14h ago

Codex Review: Didn't find any major issues. :+1:

Reviewed commit: 80d2f44926

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

▸ 3 bot/status comments hidden

@linear-code[bot]15h ago

Description: The API Key, Source, and Service fields in the SIEM Log Forwarding configuration screen do not enforce any maximum character limit. Users can enter excessively long values without receiving validation feedback or input restrictions.

Steps to Reproduce:

Navigate to Settings > SIEM Forwarding.
Select any available provider (Datadog, Sumo Logic, or Splunk).
Enter an excessively long string into the API Key field.
Enter an excessively long string into the Source field.
Enter an excessively long string into the Service field.
Observe the behavior of the form.

Expected Result: The fields should enforce reasonable character limits and/or provide validation messages when the allowed length is exceeded.

Actual Result: The fields accept unlimited character input without any visible validation, restriction, or user feedback.

Screen Capture 09-06-26, 17.20.06.mp4

@vercel[bot]15h ago

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions

loading diff…