@VANDRANKIchecks…fix/reserved-name-alias-and-required-check → next1 files · +3 −2review: @jkomynoupdated 1mo agoFixes #3172
json_schema_to_pydantic_field renamed reserved Python/Pydantic field names (e.g. validate -> validate_) but had two bugs:
Bug 1 - wrong alias: alias = name was evaluated after the rename, so the alias was set to validate_ instead of the original schema key validate. Any JSON payload containing the original key was rejected because Pydantic expected the renamed key.
Bug 2 - required check broken: name in required checked the renamed identifier against the required list which still contained the original name. Required fields with reserved names were silently treated as optional.
Capture original_name = name before the rename block and use it for both:
alias = original_name (so the field accepts the real schema key)original_name in required (so required status is preserved)original_name = name
if name in reserved_names:
name = f"{name}_"
alias = original_name # original schema key, not the renamed identifier
else:
alias = None
# ...
field["default"] = ... if original_name in required else default
@VANDRANKI is attempting to deploy a commit to the Composio Team on Vercel.
A member of the Team first needs to authorize it.