PR Custody

fix(cli): write fish completions to ~/.config/fish/completions/ instead of config.fish

@aptsaltchecks n/achecks…fix/fish-completions-proper-path → next1 files · +17 −1review: @jkomynoupdated 3w ago

▸Description · 1 noise

Summary

Fish completions are now written to ~/.config/fish/completions/composio.fish (a dedicated file) instead of being appended to ~/.config/fish/config.fish.

Problem

The composio install --completions command appends the entire completion script directly into config.fish. This causes:

Wrong location: Fish expects completions in ~/.config/fish/completions/, not config.fish
Broken shell startup: Long -d descriptions with nested quotes create unbalanced quote parse errors
config.fish bloat: 700+ lines of completions appended to a file meant for minimal PATH/init setup

Error observed by users:

~/.config/fish/config.fish (line 734): Unexpected end of string, quotes are not balanced

Fix

For fish shells, completions are now written to ~/.config/fish/completions/composio.fish
Uses atomic write (tmp file + rename) matching the existing pattern
Fish automatically sources all files in the completions directory on first command use
PATH setup remains in config.fish (this is correct behavior for fish)

Test plan

Run composio install --completions on fish shell
Verify ~/.config/fish/completions/composio.fish is created
Verify config.fish only contains PATH setup, not completions
Verify fish -n ~/.config/fish/completions/composio.fish passes
Verify tab completion works for composio commands

Fixes #3147

▸ 1 bot/status comment hidden

@vercel[bot]3w ago

Someone is attempting to deploy a commit to the Composio Team on Vercel.

A member of the Team first needs to authorize it.

loading diff…