fix: classify ForbiddenOrgProjectError as FORBIDDEN instead of INTERNAL_SERVER_ERROR

@zen-agentchecks n/achecks…zen/fix-trpc-forbidden-error-rnb463 → main1 files · +15 −1updated 2mo ago

▸Description· 1 comment · 1 noise

Description

When authServer.getSession() throws ForbiddenOrgProjectError in createTRPCContext, tRPC wraps it as INTERNAL_SERVER_ERROR because it's not a TRPCError. This causes ~238 errors/day to be misclassified as HTTP 500s, polluting error monitoring and potentially triggering unnecessary client retries.

This PR catches ForbiddenOrgProjectError and rethrows it as a proper TRPCError with FORBIDDEN code so:

Clients receive HTTP 403 instead of 500
Error logs use warn level instead of error level (~24% reduction in error log noise)
Client-side retry loops are avoided (clients typically retry 500s but not 403s)

Affected tRPC methods (by frequency): org.getOrgPlans (55x), playground.getSessionInfo (37x), playground.getApiKey (37x), users.isLegacyUser (36x), consumer.getToken (14x), and others.

How did I test this PR

Verified lint (pnpm lint) — no new warnings/errors (82 warnings, 3 errors all pre-existing)
Verified typecheck (pnpm typecheck) — no new type errors (all errors pre-existing)
Reviewed tRPC error handling flow: createTRPCContext → fetchRequestHandler.onError → logByStatusCode confirms FORBIDDEN (non-500) errors are logged at info/warn level
No existing unit tests for createTRPCContext to regress

Origin: cron-ab141b543e91 / zen-cron-015cacf26ed3

@zen-agent2mo ago

Post-PR Status

Build checks: ✅ Lint (82 warnings, 3 errors — all pre-existing on main) and typecheck (all errors pre-existing) pass with no new issues
Codex review: ✅ LGTM — "Does not introduce regressions in control flow or typing"
CI: No GitHub Actions workflows in this repo. Vercel preview deploy only.
Browser test: N/A — server-only change (tRPC error code classification in createTRPCContext), no UI modified
PR comments: None to address

This is a minimal, targeted fix: catches ForbiddenOrgProjectError in createTRPCContext and rethrows as TRPCError with FORBIDDEN code, reducing ~238 daily error log entries from INTERNAL_SERVER_ERROR to the correct FORBIDDEN classification.

▸ 1 bot/status comment hidden

@vercel[bot]2mo ago

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Apr 2, 2026 8:11am

loading diff…