PR Custody

feat(enhanced-control): beta-gated bucket-permission flow for Gmail connect

@Malayvasachecks n/achecks…claude/blissful-rubin-739e51 → main17 files · +1751 −121review: @sarahsimionescuupdated 1mo ago

GitHub

▸Description · 1 noise

Summary

Introduces Enhanced Control — a beta, allowlist-gated trust layer on top of OAuth that lets a consumer scope what their agent can actually do with a connected toolkit. Gmail is the first (and only) toolkit on the allowlist.

The flow is triggered from the existing Connect button on /~/connect/apps/gmail. When Enhanced Control is enabled for a toolkit, clicking Connect opens a two-step dialog (Configure → handoff primer) instead of running the OAuth mutation directly. The user groups Gmail's tools into Read / Write / Destructive, picks a permission per group, and is then handed off to Google's consent screen with a clear "check all permission boxes" instruction.

What ships

New shared module — src/components/core/enhanced-control/:

EnhancedControlDialog — the two-step Configure → handoff dialog with the emerald-fade hero, group list, AllTools preset dropdown, per-group permission dropdown, mock permission-boxes preview, and full-width black CTA
EnhancedControlBadge — inline/strip variants of the 🛡 Enhanced Control · BETA pill
EnhancedControlBetaCard — dismissable bottom-left announcement card (shaders lib, shimmering BETA, 6h localStorage TTL)
PermissionDropdown, GlobalPermissionDropdown, BucketRow, ConnectModal (kept available standalone)
permission-types — Bucket / Permission types, labels, icons, defaults, order

New config / helpers — src/lib/enhanced-control/:

allowlist.ts — isEnhancedControlToolkit(slug) + getEnhancedControlConfig(slug) (Gmail-only currently, with providerName: "Google")
bucket-for.ts — per-toolkit slug → Read/Write/Destructive classifier (Gmail wired; new toolkits register here)
session-storage.ts — per-toolkit TrustConfig persistence (to be swapped for a real backend write)

Real-flow integration:

/~/connect/apps listing — shield icon + tooltip on Gmail card; EnhancedControlBetaCard on the page
/~/connect/apps/[slug] — when isEnhancedControlToolkit(slug), Connect opens EnhancedControlDialog and the Available Tools section renders BucketedToolsSection (grouped by Read/Write/Destructive collapsible cards)
/prototype/connect/* sandbox routes removed — everything useful lives in the shared module and the real Gmail page

UX behaviours worth flagging

AllTools dropdown has three concrete presets — Default (risk gradient: Read=Always Allow / Write=Ask Per Session / Destructive=Always Ask), Always Ask, Always Allow. When the current per-group config doesn't match any preset, the trigger shows a non-selectable Mixed indicator.
Next is disabled with a destructive-tinted alert when all three groups are set to Deny ("Your agent can't take any actions…")
Handoff step uses a mock permission-boxes preview (muted width-varying bars + emerald check circles) to prime the user for what they'll see on Google's consent screen
Copy: groups / settings / your agent / never mentions OAuth or scopes in user-facing copy
The TrustConfig currently persists to sessionStorage; swap to a real persistence layer when the backend is ready

Reviewer notes

ConnectModal is no longer used by the integrated flow (the dialog absorbed it) but is still exported for any standalone handoff-only use.
The allowlist is intentionally a tiny in-repo map — replace with a feature flag / backend check before GA.
Dialog uses motion/react for step transitions; shaders/react powers the announcement-card background.
Production gating is inherited via the real /~/connect/apps/[slug] routes — no extra dev-only guards.

Test plan

Open /~/connect/apps — Gmail card shows shield icon + tooltip "Enhanced Control Supported"; beta announcement card appears bottom-left, dismisses and stays hidden for 6h
Open /~/connect/apps/gmail — Enhanced Control · Beta badge next to the toolkit name; Available Tools renders three collapsible group cards (Read / Write / Destructive)
Click Connect → Configure dialog opens with emerald fade, Enhanced Control · BETA badge, Gmail logo, title, description, All Tools row + three group rows with default preset applied
Global preset dropdown: Default / Always Ask / Always Allow all cascade to the three groups; changing any one group flips the global to Mixed
Set every group to Deny — Next disables, alert appears
Click Next — body transitions to handoff step with the mock permission-boxes preview and emerald shield-check Gmail logo; Back arrow returns to Configure preserving state
Continue To Google Permissions — fires real initiateConnection, OAuth popup opens
Non-allowlisted toolkit (e.g. Slack, GitHub) — existing flow unchanged, no Enhanced Control affordances
pnpm check passes

🤖 Generated with Claude Code

▸ 1 bot/status comment hidden

@vercel[bot]1mo ago

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Apr 24, 2026 7:46am

loading diff…