PR Custody

feat(enhanced-control): banner discovery flow + safer disable + UI polish

@Malayvasachecks n/achecks…claude/wizardly-robinson-2bf822 → main19 files · +961 −319review: @sarahsimionescuupdated 1w ago

▸Description · 1 noise

Three threads bundled — they share files and conventions, splitting them would create merge thrash.

EnhancedControlBetaCard on /connect/apps is now visible to every user, not just orgs that have already enabled the feature. Hides automatically once the toggle is on.
Banner CTA → /connect/settings?return_to=/connect/apps with "Enable Enhanced Control" label.
App cards always render the ShieldCheck marker for allowlisted toolkits — muted when off, brand green when on. Tooltip copy adapts.

Heading shows the green ShieldCheck icon and a neutral BETA pill.
useSearchParams reads ?return_to=, validated by safeReturnPath (must start with /, blocks //evil.com and javascript: open-redirects).
On enable + safe return_to: getConsumerConfig cache is updated via setData after a successful mutation (no immediate invalidate — the query reads a Prisma replica that can lag behind the write and would flash the banner). Toast: "Enhanced Control is on. Open any app and tap the shield to set per-tool permissions." then router.push.
Coachmark tooltip on the Switch — emerald-success branded, 10s auto-dismiss, only when arriving via ?return_to and the toggle is still off.

Toggling off opens a Dialog (dismissable by outside-click + X).
Acknowledge checkbox required before the destructive button activates.
Inline impacted-accounts list (toolkit logo, name, resolved email); prefetched while EC is on.
New tRPC procedure consumer.listEnhancedControlConnectedAccounts.
Shared identity resolution in ~/server/utils/connected-account-identity.ts.
Disable dialog only closes on successful mutation; checkbox resets on close and after confirm.

Fixed w-[180px] dropdown widths (enhanced link screen + in-app dialogs).
Bucket labels: Read, Write, Destructive with N Tools count pills.
Bucket descriptions hidden for now (description? remains optional on row components).

Addressed @shamsharoon review: removed redundant comments, inlined coachmark tooltip classes.
Merged main (resolved conflicts in general-content.tsx, enhanced-link-screen.tsx).
Fixed Bugbot cache regression: removed getConsumerConfig.invalidate() after toggle setData.

Visit /{org}/~/connect/apps with EC off → banner appears bottom-left
Click banner CTA → lands on /{org}/~/connect/settings?return_to=...
Coachmark tooltip points at the Switch, auto-dismisses after 10s
Toggle on → toast → redirect to /connect/apps → banner stays hidden (no flash)
App cards show green ShieldCheck on allowlisted toolkits when EC is on; muted when off

Toggle off → modal with impacted accounts (or error message if list fetch fails)
Disable button disabled until checkbox checked
X / outside-click closes modal; checkbox resets
Failed disable keeps modal open; successful disable closes and resets checkbox
After confirm: toast "Enhanced Control is off…"

▸ 1 bot/status comment hidden

@vercel[bot]4w ago

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Jun 5, 2026 1:58am

loading diff…