PR Custody

fix(data-table): make clickable rows keyboard accessible

@Malayvasachecks n/achecks…claude/sharp-banzai-bef209 → main1 files · +15 −1updated 3d ago

▸Description · 1 noise

Problem

Every virtualized listing table (Logs, Sessions, Triggers, Users, Auth Configs, Connected Accounts, Support, user-detail tabs) opens its detail view via onRowClick — but the <tr> had no tabIndex, no key handler, and no focus indicator. Keyboard and assistive-technology users could not reach or activate any row. Verified live in production via DOM inspection: tabIndex: -1, role: null on clickable rows.

WCAG 2.1 A failures: 2.1.1 Keyboard, 2.4.7 Focus Visible.

Change (single file)

src/components/core/data-table/data-table.tsx, data-row branch only, all conditional on onRowClick:

tabIndex={0} — rows join the tab order
Enter/Space invoke onRowClick(row); preventDefault() stops Space from scrolling the virtualized container
focus-visible: inset 2px ring outline + bg-muted/50 tint (matches the hover treatment; inset so it isn't clipped by the scroll container)
Keys bubbling from inner interactive cells (copy buttons, links) are ignored via e.target !== e.currentTarget
No role="button" — <tr> keeps native row semantics for screen readers
Non-clickable tables and group-header rows are untouched

Out of scope (deferred)

Roving tabindex / arrow-key navigation and focus restoration on virtualization — follow-up.

Verification

pnpm check passes (oxlint + tsgo + tenant-scope audit)
Manual: Tab reaches rows on /logs; Enter and Space open the detail panel; Space doesn't scroll; mouse clicks show no outline; non-clickable tables unchanged

🤖 Generated with Claude Code

▸ 1 bot/status comment hidden

@vercel[bot]3d ago

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
dashboard	Ready	Preview, Comment	Jun 10, 2026 10:09am

loading diff…