PR Custody

fix: set creates_new_app=True in CreateAppWorkflow

@zen-agentchecks n/achecks…zen/fix-create-app-new-app-dir-0fdfnb → next1 files · +1 −0updated 2mo ago

▸Description· 1 comment

Why

The CreateAppWorkflow is designed to create brand-new apps from scratch (discover endpoints, build actions, test them), but it inherited the base class default of creates_new_app = False. This caused _setup_repo() to raise FileNotFoundError instead of creating the app directory when the app doesn't already exist in Mercury.

This bug caused workflow pgzi272b (create-app for googlecontacts) to fail with:

App googlecontacts not found in /tmp/mercury

What

Add creates_new_app = True to CreateAppWorkflow, matching ConfigGeneratorWorkflow which already sets this correctly

How to Test

Run a create-app workflow for a toolkit that doesn't yet exist in Mercury master (e.g., googlecontacts)
Verify the workflow creates the app directory instead of failing with FileNotFoundError
Existing apps should be unaffected since _setup_repo() skips directory creation when the path already exists

Pre-Review Checklist

I have self-reviewed this PR

Notes

ConfigGeneratorWorkflow already correctly sets creates_new_app = True at config_generator.py:29
make fmt && make chk pass cleanly

@zen-agent2mo ago

Post-PR Status Update

Step	Status	Details
Build checks	:white_check_mark: Passed	`make fmt` + `make chk` — all green
Codex review	:white_check_mark: Passed	No issues found — "did not identify any regressions"
CI checks	:white_check_mark: 7/7 passed	check-lines, detect-secrets, run-lint, run-tests, detect-changes, integration-tests, app checks
Unit tests	:white_check_mark: Covered	CI `run-tests` passed; base class `_setup_repo()` handles the flag
E2E/runtime	:information_source: N/A	Integrator runs on ECS, not locally — no local E2E path
PR comments	:white_check_mark: None to address	No review comments

All post-PR lifecycle items complete. Ready for review.

loading diff…