@zen-agent1mo ago
Post-PR status update
/build-checks: PASS —make fmtclean,make chkclean (ruff format / lint / import-order / pyrefly).- Codex review (
/codex-review-loop): 3 iterations, 5 findings — all fixed:- Round 1, P3 (real): missing
skip_reasonon the processor opt-out branch caused the new skip path to be bucketed asskipped_dedupby the tool-failure / batch-poller callers and emit a spuriouspattern_dedupedmetric. AddedSkipReason.LEARNING_DISABLED_FOR_PROJECT+PipelineStats.skipped_learning_disabledand updated both callers. (fb76ef82) - Round 1, P1 (false positive but worth clarifying): clarified the module docstring to spell out that the admin endpoint returns snake_case
learning_pipeline_enabled(the underlying Zod / Postgres field islearningPipelineEnabled). (fb76ef82) - Round 2, P2(a): staging ECS sets
ENV=staging, notAPOLLO_ENV. AddedAPOLLO_ENV/ENVresolution mirroringcommon/composio_client.pyso staging picksstaging-backend.composio.dev+COMPOSIO_STAGING_ADMIN_TOKEN. (8eea66f6,20cc2e16) - Round 2, P2(b):
bool(None) → Falsecould silently disable the fixer. Strictisinstance(_, bool)check; non-bool / null / missing payloads fail open and are not cached. (8eea66f6) - Round 3, P2(a): mixed pattern with one opted-out projectId and one log missing
projectIdwas being skipped; that's not safe (the unknown row might come from an opted-in project). Now requires every sample log to carry a known projectId before skipping. (20cc2e16) - Round 3, P2(b): Apollo lookup failures only logged at WARN; switched to
logger.exception()per repo guidelines so an outage that bypasses the gate surfaces in Datadog. (5dc0a428)
- Round 1, P3 (real): missing
- Cursor BugBot: 1 finding (same as Codex round 1 P3, on the original commit) — already fixed in .