PR Custody

[LOW PRIORITY] refactor: Switch from jsonref to prance for OpenAPI parsing

@AgentWrapperchecks n/achecks…refactor/use-prance-separate-pr → next6 files · +1350 −844updated 4mo ago

▸Description

Why

Follow-up to PR #861 to reduce custom code and improve maintainability. PR #861 fixed the exponential OOM issue by skipping JsonRef proxy conversion. This PR takes it further by replacing jsonref with a mature library.

Important: This PR is based on #861 and should be merged after #861 is merged to next.

What

Replace custom jsonref implementation with the prance library, eliminating JsonRef proxy complexity entirely.

Changes:

Dependencies:
- Production: Replace jsonref>=1.1.0,<2 with prance[osv]>=25.0.0,<26
- Dev: Keep jsonref>=1.1.0,<2 (still used in test resources)
openapi_parser.py: Simplify _load_and_resolve_spec() from 56 lines to 23 lines (58% reduction)
Type system: Change Mapping[...] back to Dict[...] since prance returns plain dicts
Type checks: Change isinstance(x, Mapping) back to isinstance(x, dict)

Benefits:

Prance returns plain dicts instead of proxy objects
Built-in cycle detection and caching for shared references
Automatic JSON/YAML format detection
Better error handling from mature library
Less custom code to maintain (100+ lines removed)

How to Test

# Run extractor tests (22 tests)
uv run pytest cortex/tests/test_agents/test_action_finder/test_extractors.py -v

# Run code quality checks
make fmt && make chk

Notes

Prance is a well-maintained library (last release: 2025-01-08) with 345+ stars
All tests pass ✅
All code quality checks pass ✅
This change is purely a refactor with no functional changes
Builds on #861 - merge that first

loading diff…