PR Custody

PRPR Custody

fix(onenote): validate anyOf/oneOf site inputs (INT-2047)

@AgentWrapperchecks n/achecks…fix/INT-2047-onenote-anyof-oneof → master6 files · +84 −38updated 1mo ago

GitHub

▸Description · 1 noise

Summary

Adds validators for ambiguous OneNote site copy destination inputs.
Makes site-specific OneNote actions require site_id instead of silently falling back to /me.
Keeps this PR scoped to action fixes only; removed the toolkit-specific pytest guard because CI checks should stay generic/cross-toolkit where possible.

Original builder context

Original OneNote builder PR: https://github.com/ComposioHQ/mercury/pull/22479
Workflow ID / run number from that PR body: erq097dj / 1
Connection ID from that PR body: ca_7hCbRked5SCq
Current admin API could not resolve that old connection ID, so live verification used refreshed active OneNote connection ca__lLuYLtbUPI- plus known site resources from the original PR body.

Verification

ruff check on changed action files
Local validator smoke script confirmed invalid request shapes are rejected
OneNote pagination CI check still passes: uv run python ci_checks/lint_missing_pagination_params.py apps/onenote/actions/*.py → 0 violations
Deterministic verify/fix artifact report generated locally: /tmp/onenote-anyof-oneof-bug-cleanup-report.html

Live site verification

Using known OneNote site resources from the original builder PR:

get_site_pages_preview.py: live happy path passed (HTTP 200) and missing site_id is rejected.
create_site_notebooks_sections.py: live happy path passed (HTTP 201) and missing site_id is rejected.
site_copy_notebook.py: live happy path passed (HTTP 202) and folder without destinationId is rejected.
copy_site_page_to_section_3.py: invalid destination combinations are rejected by the request model; live id-only copy against the available page/section pair returns Graph 404, and full site tuple returns v1.0 Graph 500 while beta returns 202, so its live happy path remains Graph endpoint-behavior blocked for the available fixture.

INT-2047

▸ 1 bot/status comment hidden

@linear-code[bot]1mo ago

Summary

Fix existing Mercury action files that expose size-only pagination (e.g. limit, top, page_size) while their response model exposes continuation metadata (next, next_token, cursor, @odata.nextLink, pagination links), but the request model has no traversal field and the action does not paginate internally.

Found while validating INT-2045 / PR #23361 pagination CI coverage.

Scope

Current deterministic check finds 70 action files that likely need pagination fixes after excluding the 3 documented schema false positives.
Separate schema-inaccuracy tickets were filed for false positives: #23383 Google Contacts, #23384 Alpha Vantage, #23385 Radar.
The CI PR intentionally does not fix app files; this ticket tracks baseline cleanup so the rule can eventually run globally.

Suggested fix pattern

Add the provider-specific traversal field to the request model and pass it through (cursor, page_token, offset, skiptoken, next_link, page[number], etc.), or
Implement internal pagination intentionally, or
If docs prove the response continuation field is wrong, remove/correct that response schema and document it.

Action files to fix

ably (3)

asana (1)

apps/asana/actions/search_tasks_in_workspace.py

loading diff…

Summary

Adds validators for ambiguous OneNote site copy destination inputs.

Makes site-specific OneNote actions require site_id instead of silently falling back to /me.

Keeps this PR scoped to action fixes only; removed the toolkit-specific pytest guard because CI checks should stay generic/cross-toolkit where possible.

Original builder context

Original OneNote builder PR: https://github.com/ComposioHQ/mercury/pull/22479

Workflow ID / run number from that PR body: erq097dj / 1

Connection ID from that PR body: ca_7hCbRked5SCq

Current admin API could not resolve that old connection ID, so live verification used refreshed active OneNote connection ca__lLuYLtbUPI- plus known site resources from the original PR body.

Verification

ruff check on changed action files

Local validator smoke script confirmed invalid request shapes are rejected

OneNote pagination CI check still passes: uv run python ci_checks/lint_missing_pagination_params.py apps/onenote/actions/*.py → 0 violations

Deterministic verify/fix artifact report generated locally: /tmp/onenote-anyof-oneof-bug-cleanup-report.html

Live site verification

Using known OneNote site resources from the original builder PR:

get_site_pages_preview.py: live happy path passed (HTTP 200) and missing site_id is rejected.

create_site_notebooks_sections.py: live happy path passed (HTTP 201) and missing site_id is rejected.

site_copy_notebook.py: live happy path passed (HTTP 202) and folder without destinationId is rejected.

copy_site_page_to_section_3.py: invalid destination combinations are rejected by the request model; live id-only copy against the available page/section pair returns Graph 404, and full site tuple returns v1.0 Graph 500 while beta returns 202, so its live happy path remains Graph endpoint-behavior blocked for the available fixture.

INT-2047

Summary

Found while validating INT-2045 / PR #23361 pagination CI coverage.

Scope

Current deterministic check finds 70 action files that likely need pagination fixes after excluding the 3 documented schema false positives.

Separate schema-inaccuracy tickets were filed for false positives: #23383 Google Contacts, #23384 Alpha Vantage, #23385 Radar.

The CI PR intentionally does not fix app files; this ticket tracks baseline cleanup so the rule can eventually run globally.

Suggested fix pattern

Add the provider-specific traversal field to the request model and pass it through (cursor, page_token, offset, skiptoken, next_link, page[number], etc.), or

Implement internal pagination intentionally, or

If docs prove the response continuation field is wrong, remove/correct that response schema and document it.

fix(onenote): validate anyOf/oneOf site inputs (INT-2047)

Summary

Original builder context

Verification

Live site verification

Summary

Scope

Suggested fix pattern

Action files to fix

ably (3)

asana (1)

Summary

Original builder context

Verification

Live site verification

Summary

Scope

Suggested fix pattern

Action files to fix

ably (3)

asana (1)

brex (2)

cloudcart (1)

constant_contact (18)

dropbox (16)

klaviyo (1)

microsoft_teams (5)

mixmax (1)

moz (1)

one_drive (4)

onenote (11)

outlook (1)

share_point (1)

supadata (1)

zendesk (3)