@kaavee315checks…codex/fix-shared-credential-exposure-vulnerability → master2 files · +12 −18review: @rohanprabhureview: @sarthakreview: @acsrujanreview: @anshugarg15updated 1w agoannotateFieldWithSharedCredentials that copied values from shared_credentials into the public expected_input_fields.default, which could leak admin-provided secrets when is_secret was absent or incorrect.required).annotateFieldWithSharedCredentials to never mutate the field default from shared_credentials; it now only marks is_available_as_shared_credentials and forces required: false for covered fields. (apps/apollo/src/lib/auth_config/utils/annotateFieldWithSharedCredentials.ts)default is not populated from shared_credentials, including back-compat and empty-string cases). (apps/apollo/src/lib/auth_config/utils/annotateFieldWithSharedCredentials.test.ts)pnpm with-env vitest run src/lib/auth_config/utils/annotateFieldWithSharedCredentials.test.ts, but the run failed in this environment due to missing secrets/dependency (doppler) and required environment variables, so tests could not be executed here (failure: environment validation errors for DATABASE_URL, JWT_SECRET, etc.).Based on git blame analysis of 2 file(s):
| Contributor | Contribution | Files |
|---|---|---|
| Zen | 100% | 2 |
Based on git history, Zen would be good reviewer(s) for this PR.
🤖 Based on git blame with recency weighting (recent edits count more).