PR Custody

fix(apollo): bound Metronome webhook body reads

@kaavee315checks n/achecks…codex/fix-unbounded-request-body-vulnerability → master5 files · +176 −2review: @sohamganatrareview: @anshugarg15updated 1w ago

GitHub

▸Description · 1 noise

Motivation

Prevent an unauthenticated Metronome webhook endpoint from DoS/availability issues by reading attacker-controlled request bodies without any size bound, which allowed large arrayBuffer() + Buffer.toString() allocations before signature verification.

Description

Add a METRONOME_WEBHOOK_MAX_BODY_BYTES (64 KiB) and a streaming readBoundedRawBody(request, maxBytes) that rejects oversized Content-Length values and enforces the same cap while streaming chunks from request.body before decoding to string.
Replace the previous unbounded await c.req.raw.clone().arrayBuffer() usage with the bounded reader wrapped in safeExecuteAsync so read errors short-circuit before constructing the Metronome client or calling webhooks.unwrap.
Add a typed 413 error for Metronome webhooks by extending ErrorCodes/MetronomeWebhookError with PayloadTooLarge, and document 413 in the route responses OpenAPI definition.
Add a regression test case ensuring an oversized request (via Content-Length) returns 413 and does not call the Metronome client or handler.

Testing

Ran formatting/linting (oxfmt / oxlint) on the modified files: succeeded.
Built @composio/lib bundle required by the test environment: succeeded.
Added a unit test covering oversized Content-Length short-circuit behavior; attempted to run vitest for the route test, but test execution was blocked by missing environment/prerequisites (missing generated Prisma client and a failed Prisma engine download), so the test run could not be completed in CI-like environment.
Manual static checks (type/lint/format) and test additions are in place; the regression test will validate the fix once the test environment has the generated Prisma client and required secrets available.

Codex Task

▸ 1 bot/status comment hidden

@github-actions[bot]1w ago

🔍 Suggested Reviewers

Based on git blame analysis of 3 file(s):

Contributor	Contribution	Files
anshugarg15	20%	1
shamsharoon	18%	3
lingalarahul7	17%	1
devin-ai-integration[bot]	15%	1
Zen	6%	1

💡 Recommendation

Based on git history, anshugarg15 or shamsharoon would be good reviewer(s) for this PR.

🤖 Based on git blame with recency weighting (recent edits count more).

loading diff…