@kaavee315checks…codex/fix-unbounded-webhook-batch-vulnerability → master5 files · +117 −5updated 1w agoMAX_WEBHOOK_EVENTS_PER_REQUEST = 100 in Apollo and reject batched parses in parseBatched() when the event count exceeds the cap so oversized batches are rejected before allocation or forwarding to Thermos (apps/apollo/src/lib/triggers/webhook_ingress/event_parser.ts).parseEvents() rejects oversized arrays and an ingress test that verifies oversized Asana batches return 400 and are not sent to Thermos (apps/apollo/.../event_parser.test.ts, trigger_event.test.ts).maxBulkWebhookTriggerEvents = 100 and limiting the request body to 10 MiB via http.MaxBytesReader, and reject bulk requests exceeding the cap before any per-event encryption/DB work (apps/thermos/handlers/webhook_trigger_bulk.go).apps/thermos/handlers/webhook_trigger_bulk_test.go).pnpm --dir apps/apollo exec oxfmt --check for changed files, which succeeded.go test ./handlers -run TestInsertBulkWebhookTriggerHandler_RejectsTooManyEvents -count=1, which passed locally in the Thermos handler package.vitest for the modified parser and webhook handler, but full test runs were blocked by environment constraints (missing Doppler secrets, missing generated Prisma client and Prisma engine download failures), so those tests could not be completed in this environment.pnpm --dir packages/db db:generate to produce Prisma client for test runs, but the Prisma engine download failed with a 403 from binaries.prisma.sh, preventing generation in this environment.Based on git blame analysis of 5 file(s):
| Contributor | Contribution | Files |
|---|---|---|
| anshugarg15 | 100% | 4 |
| sarthak | 0% | 1 |
Based on git history, anshugarg15 or sarthak would be good reviewer(s) for this PR.
🤖 Based on git blame with recency weighting (recent edits count more).