PR Custody

fix(thermos): exclude private toolkit groups from onprem dump

@kaavee315checks n/achecks…codex/fix-on-prem-dump-data-leak → master2 files · +30 −49updated 1w ago

▸Description · 1 noise

Prevent cross-tenant data leakage by ensuring the on-prem DB dump embedded into self-hosted images does not include non-default (customer/private) toolkit groups and their sensitive artifacts.
The previous milestone dump logic materialized every toolkit where group != 'default' and then exported related tools, triggers, and bundle artifacts, causing redistribution of private integration metadata in build artifacts.

Removed the non_default CTE and its UNION from the rolling-window toolkit ID query so only group = 'default' toolkit IDs are materialized from Monday snapshots.
Restricted EXTRA_TOOLKIT_VERSIONS backfill lookups to group = 'default' so explicit backfills cannot pull private/customer groups into the dump.
Removed insertion/population of non-default toolkits from the latest-mode restore SQL and the restore_latest_toolkit_ids population so latest-mode no longer restores private groups.
Added and updated unit tests to assert the rolling-window SQL, extra-version lookup SQL, and toolkit postamble do not include non-default toolkit groups.

Ran go test ./onprem/registry_dump and the package tests passed successfully (ok).
Ran go test ./onprem/... to run onprem-related tests and the suite passed successfully (ok).

▸ 1 bot/status comment hidden

@github-actions[bot]1w ago

Based on git blame analysis of 2 file(s):

Contributor	Contribution	Files
Srujan	89%	2
Rohan Prabhu	11%	2

Based on git history, Srujan or Rohan Prabhu would be good reviewer(s) for this PR.

🤖 Based on git blame with recency weighting (recent edits count more).

loading diff…