PR Custody

Surface ToolRouter slug warnings

@shreysingla11checks n/achecks…fix/toolrouter-slug-resolution-warnings → fix/toolrouter-slug-resolution-behavior11 files · +428 −105review: @sohamganatrareview: @kaavee315review: @anshugarg15updated 5d ago

GitHub

▸Description

Summary

Adds session warnings for alias and historical/deleted tool slug usage during ToolRouter create/patch.

New warning codes:

TOOL_SLUG_ALIAS_USED
TOOL_SLUG_HISTORICAL

Existing warning behavior is preserved:

PRELOAD_TOOLS_HIGH_CONTEXT_USAGE

Behavior

Alias warning

When a submitted slug resolves as a current alias, create/patch succeeds and the response includes a warning telling the user the tool was renamed to the canonical slug. The alias continues to work; the warning is advisory.

Historical/deleted warning

When a submitted slug resolves as historical, create/patch succeeds and the response includes a warning telling the user the tool is no longer available in the latest toolkit version. The tool remains in config but is not exposed or executable by the behavior PR below this one.

Design Notes

Warning facts are produced by the existing validation/preload resolver calls.
No extra Thermos response-time lookups are added to GET or attach.
Plain GET/attach only return warnings derivable from stored config without live slug recomputation.
Dedup-hit create responses still surface warning facts for the new request by moving create validation before dedup.
The warning framework is facts-based and append-only, so future warnings can be added by producing new facts and mapping them to stable warning codes/messages.

Testing

Ran targeted Apollo lint on the edited files:

cd apps/apollo && pnpm lint src/lib/toolRouterV2/utils/session_warning_facts.ts src/lib/toolRouterV2/features/session/util/sessionResponse.ts src/lib/toolRouterV2/features/session/helpers/validateSessionConfigFields.ts src/lib/toolRouterV2/utils/preload.ts src/lib/toolRouterV2/features/session/create.ts src/lib/toolRouterV2/features/session/patch.ts src/pages/api/v3/tool_router/session.ts 'src/pages/api/v3/tool_router/session/[session_id]/index.ts' 'src/pages/api/v3.1/tool_router/session/[session_id]/index.ts' src/lib/toolRouterV2/schema/api.ts

loading diff…