@kaavee315draftchecks…fix/parse-connection-status-enum → master3 files · +115 −1updated 6d agoAdded parseConnectionStatusEnum(raw: string): Result<ConnectionStatusEnum, Error> in apps/apollo/src/lib/connected_accounts/schemes/constants.ts, implemented with z.nativeEnum(ConnectionStatusEnum).safeParse.
Replaced the unsafe as ConnectionStatusEnum cast at reinitiateRedirectableAccount.ts line 96 with a call to this parser. If the DB returns an unexpected status string, the function now returns a typed Err(ToolAuthError.BadConnectedAccountState) before reaching the switch, eliminating the unhandled-arm failure mode. All existing valid enum values still flow through the switch correctly.
ConnectionStatusEnum's definition, imports (ts-results, zod) are already present throughout the codebase and no circular dependency is introduced, the Err path mirrors the surrounding ts-results style, and the Ok path preserves the exact pre-existing switch behaviour.connectionData.val.status is typed as string downstream of parseConnectionDataAndValidate - reviewer should confirm that the Zod schema there does not already coerce/validate the status, which would make this guard redundant but harmless.🤖 Generated with Claude Code